Skip to content

[Security] Fix added $token argument to UserCheckerInterface::checkPostAuth() #61194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Jul 22, 2025
Merged

[Security] Fix added $token argument to UserCheckerInterface::checkPostAuth() #61194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/SecurityExtensionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,7 +986,7 @@ public function checkPreAuth(UserInterface $user): void
{
}

public function checkPostAuth(UserInterface $user): void
public function checkPostAuth(UserInterface $user, ?TokenInterface $token = null): void
{
}
}
Expand Down
11 changes: 5 additions & 6 deletions src/Symfony/Component/Security/Core/User/ChainUserChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,15 @@ public function checkPreAuth(UserInterface $user): void
}
}

public function checkPostAuth(UserInterface $user /* , TokenInterface $token */): void
/**
* @param ?TokenInterface $token
*/
public function checkPostAuth(UserInterface $user /* , ?TokenInterface $token = null */): void
{
$token = 1 < \func_num_args() ? func_get_arg(1) : null;

foreach ($this->checkers as $checker) {
if ($token instanceof TokenInterface) {
$checker->checkPostAuth($user, $token);
} else {
$checker->checkPostAuth($user);
}
$checker->checkPostAuth($user, $token);
}
}
}
5 changes: 4 additions & 1 deletion src/Symfony/Component/Security/Core/User/InMemoryUserChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@ public function checkPreAuth(UserInterface $user): void
}
}

public function checkPostAuth(UserInterface $user): void
/**
* @param ?TokenInterface $token
*/
public function checkPostAuth(UserInterface $user /* , ?TokenInterface $token = null */): void
{
}
}
5 changes: 4 additions & 1 deletion src/Symfony/Component/Security/Core/User/UserCheckerInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

namespace Symfony\Component\Security\Core\User;

use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Exception\AccountStatusException;

/**
Expand All @@ -33,7 +34,9 @@ public function checkPreAuth(UserInterface $user): void;
/**
* Checks the user account after authentication.
*
* @param ?TokenInterface $token
*
* @throws AccountStatusException
*/
public function checkPostAuth(UserInterface $user /* , TokenInterface $token */): void;
public function checkPostAuth(UserInterface $user /* , ?TokenInterface $token = null */): void;
}