Skip to content

[FrameworkBundle][SecurityBundle] Remove autowiring aliases for RateLimiterFactory #61155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Jul 19, 2025
Merged

[FrameworkBundle][SecurityBundle] Remove autowiring aliases for RateLimiterFactory #61155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions UPGRADE-8.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ FrameworkBundle
* Make `ConfigBuilderCacheWarmer` class `final`
* Make `TranslationsCacheWarmer` class `final`
* Make `ValidatorCacheWarmer` class `final`
* Remove autowiring aliases for `RateLimiterFactory`; use `RateLimiterFactoryInterface` instead

HttpFoundation
--------------
Expand Down Expand Up @@ -443,6 +444,7 @@ SecurityBundle
+ algorithms: ['RS256']
+ keyset: 'https://example.com/.well-known/jwks.json'
```
* Remove autowiring aliases for `RateLimiterFactory`; use `RateLimiterFactoryInterface` instead

Serializer
----------
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ CHANGELOG
* Make `ConfigBuilderCacheWarmer` class `final`
* Make `TranslationsCacheWarmer` class `final`
* Make `ValidatorCacheWarmer` class `final`
* Remove autowiring aliases for `RateLimiterFactory`; use `RateLimiterFactoryInterface` instead

7.4
---
Expand Down
10 changes: 1 addition & 9 deletions src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3296,15 +3296,7 @@ private function registerRateLimiterConfiguration(array $config, ContainerBuilde
$limiterConfig['id'] = $name;
$limiter->replaceArgument(0, $limiterConfig);

$factoryAlias = $container->registerAliasForArgument($limiterId, RateLimiterFactory::class, $name.'.limiter');

if (interface_exists(RateLimiterFactoryInterface::class)) {
$container->registerAliasForArgument($limiterId, RateLimiterFactoryInterface::class, $name.'.limiter', $name);

$factoryAlias->setDeprecated('symfony/framework-bundle', '7.3', 'The "%alias_id%" autowiring alias is deprecated and will be removed in 8.0, use "RateLimiterFactoryInterface" instead.');
$container->getAlias(\sprintf('.%s $%s.limiter', RateLimiterFactory::class, $name))
->setDeprecated('symfony/framework-bundle', '7.3', 'The "%alias_id%" autowiring alias is deprecated and will be removed in 8.0, use "RateLimiterFactoryInterface" instead.');
}
$container->registerAliasForArgument($limiterId, RateLimiterFactoryInterface::class, $name.'.limiter', $name);
}

if ($compoundLimiters && !class_exists(CompoundRateLimiterFactory::class)) {
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Bundle/SecurityBundle/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ CHANGELOG
* Remove the deprecated `algorithm` and `key` options from the OIDC token handler configuration, use `algorithms` and `keyset` instead
* Remove `LazyFirewallContext::__invoke()`
* Make `ExpressionCacheWarmer` class `final`
* Remove autowiring aliases for `RateLimiterFactory`; use `RateLimiterFactoryInterface` instead

7.4
---
Expand Down
10 changes: 1 addition & 9 deletions ...ony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/LoginThrottlingFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,14 +117,6 @@ private function registerRateLimiter(ContainerBuilder $container, string $name,
$limiterConfig['id'] = $name;
$limiter->replaceArgument(0, $limiterConfig);

$factoryAlias = $container->registerAliasForArgument($limiterId, RateLimiterFactory::class, $name.'.limiter');

if (interface_exists(RateLimiterFactoryInterface::class)) {
$container->registerAliasForArgument($limiterId, RateLimiterFactoryInterface::class, $name.'.limiter', $name);

$factoryAlias->setDeprecated('symfony/security-bundle', '7.4', 'The "%alias_id%" autowiring alias is deprecated and will be removed in 8.0, use "RateLimiterFactoryInterface" instead.');
$container->getAlias(\sprintf('.%s $%s.limiter', RateLimiterFactory::class, $name))
->setDeprecated('symfony/security-bundle', '7.4', 'The "%alias_id%" autowiring alias is deprecated and will be removed in 8.0, use "RateLimiterFactoryInterface" instead.');
}
$container->registerAliasForArgument($limiterId, RateLimiterFactoryInterface::class, $name.'.limiter', $name);
}
}
Loading