[Console] fix profiler with overridden run() method
#61138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
vinceAmstoutz
changed the title
run() methodrun() method
vinceAmstoutz
force-pushed
the
fix/61134
branch
2 times, most recently
from
5a381da to
0a2a602
Compare
Member
|
The test files are missing the license header. |
vinceAmstoutz
force-pushed
the
fix/61134
branch
2 times, most recently
from
b058b1f to
0353eb1
Compare
Contributor
Author
The missing license headers have been added and yes, version 6.4 is affected, so I changed the target from version 7.2 to version 6.4. |
src/Symfony/Component/Console/Tests/Command/TraceableCommandTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
fix/61134
branch
from
8d930fc to
fb0cd65
Compare
Member
|
Thank you @vinceAmstoutz. |
Contributor
|
This breaks the protected functions decoration. We need to either delete some (now useless) code or find another way to fix this. |
This was referenced Jul 31, 2025
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a command overrides the
run()method, using the--profileoption would bypass this custom logic. This was caused byTraceableCommandcallingparent::run()instead of delegating the call to the decorated command.This change ensures
$this->command->run()is called, preserving the overridden logic and allowing the profiler to work as expected.