[Serializer] Fix readonly property initialization from incorrect scope
#61028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santysisi
force-pushed
the
fix/readonly-property-initialization
branch
5 times, most recently
from
2f87dc4 to
5c28257
Compare
| } | ||
|
|
||
| $reflectionProperty->setValue($object, $value); | ||
| if (!$reflectionProperty->isReadOnly()) { |
Member
There was a problem hiding this comment.
I suppose we should deal with asymmetric visibility also?
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing that out!
I tested the current implementation using properties with asymmetric visibility in PHP 8.4 and everything works as expected. The values are correctly set using ReflectionProperty::setValue() without throwing errors.
I believe this is because, starting from PHP 8.4.0, ReflectionProperty::setValue() still bypasses visibility restrictions (including asymmetric ones)
To make this explicit, I’ve added some tests that cover this behavior specifically for PHP 8.4.
Let me know if you'd prefer a stricter approach that checks write visibility explicitly.
santysisi
force-pushed
the
fix/readonly-property-initialization
branch
from
5c28257 to
caee87a
Compare
santysisi
force-pushed
the
fix/readonly-property-initialization
branch
from
caee87a to
79c2ea6
Compare
nicolas-grekas
approved these changes
Jul 8, 2025
OskarStark
changed the title
readonly property initialization from incorrect scope
dunglas
approved these changes
Jul 8, 2025
mtarld
approved these changes
Jul 9, 2025
Member
|
Thank you @santysisi. |
This was referenced Jul 31, 2025
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readonly properties couldn't be initialized during denormalization due to scope restrictions. This change checks if a property is
readonlyand uninitialized, if so, it sets the value using the declaring class's scope.Also added a safety check to throw a
LogicExceptionif areadonlyproperty is already initialized, to avoid accidental mutation.