Skip to content

[SecurityBundle] Add missing fixXmlConfig() calls #60996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OskarStark wants to merge 3 commits into from
Closed

[SecurityBundle] Add missing fixXmlConfig() calls #60996

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31261a8
[SecurityBundle] Add missing fixXmlConfig() calls for OIDC token hand…
OskarStark Jun 30, 2025
d9f1aad
Update src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security…
OskarStark Jul 2, 2025
439fd16
Move fixXmlConfig() calls to parent node level
OskarStark Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...undle/SecurityBundle/DependencyInjection/Security/AccessToken/OidcTokenHandlerFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ public function addConfiguration(NodeBuilder $node): void
$node
->arrayNode($this->getKey())
->fixXmlConfig($this->getKey())
->fixXmlConfig('issuer')
Copy link
Member

@fabpot fabpot Aug 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is for 7.3.

Copy link
Contributor Author

@OskarStark OskarStark Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See

->fixXmlConfig('algorithm')
Copy link
Member

@fabpot fabpot Aug 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one can only work in 8.0 as it already exists in 7.4 (not even sure that this is a good idea as the semantic is not going to be the same between the 2 versions).

Copy link
Contributor Author

@OskarStark OskarStark Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See

->validate()
->ifTrue(static fn ($v) => !isset($v['discovery']) && !isset($v['keyset']))
->thenInvalid('You must set either "discovery" or "keyset".')
Expand Down
Loading