[Translation] Rework PhpAstExtractor tests organization for future improvements
#60854
+609
−193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welcoMattic
force-pushed
the
translation/php-ast-extractor-tests-rework
branch
2 times, most recently
from
19b3d28 to
2ed841f
Compare
stof
requested changes
Jun 20, 2025
src/Symfony/Component/Translation/Tests/Extractor/Visitor/AbstractVisitorTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Translation/Tests/Extractor/Visitor/AbstractVisitorTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Translation/Tests/Extractor/Visitor/ConstraintVisitorTest.php
Outdated
Show resolved
Hide resolved
...mfony/Component/Translation/Tests/Fixtures/extractor-php-ast/form-type-visitor/form-type.php
Outdated
Show resolved
Hide resolved
...mfony/Component/Translation/Tests/Fixtures/extractor-php-ast/form-type-visitor/form-type.php
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,47 @@ | |||
| This template is used for translation message extraction tests | |||
| <?php new TranslatableMessage('translatable single-quoted key'); ?> | |||
Member
There was a problem hiding this comment.
isn't this missing a use statement ?
Contributor
There was a problem hiding this comment.
Indeed. Also TransMethodVisitor has be updated to check the full classname.
welcoMattic
force-pushed
the
translation/php-ast-extractor-tests-rework
branch
from
2ed841f to
23ead95
Compare
stof
reviewed
Jun 20, 2025
src/Symfony/Component/Translation/Extractor/Visitor/AbstractVisitor.php
Outdated
Show resolved
Hide resolved
OskarStark
changed the title
PhpAstExtractor tests organization for future improvements
Jean-Beru
force-pushed
the
translation/php-ast-extractor-tests-rework
branch
from
56c8e7c to
9e34c67
Compare
Neirda24
reviewed
Sep 1, 2025
src/Symfony/Component/Translation/Extractor/Visitor/TranslatableMessageVisitor.php
Show resolved
Hide resolved
stof
reviewed
Sep 1, 2025
src/Symfony/Component/Translation/Tests/Extractor/Visitor/AbstractVisitorTestCase.php
Outdated
Show resolved
Hide resolved
...mfony/Component/Translation/Tests/Fixtures/extractor-php-ast/form-type-visitor/form-type.php
Outdated
Show resolved
Hide resolved
stof
reviewed
Sep 1, 2025
| $this->assertEquals(['sources' => [self::FIXTURES_FOLDER.'translation.html.php:37']], $catalogue->getMetadata('other-domain-test-no-params-short-array', 'not_messages')); | ||
| $this->assertEquals(['sources' => [self::FIXTURES_FOLDER.'translation-73.html.php:8']], $catalogue->getMetadata("nowdoc\nindented\n further")); | ||
|
|
||
| $this->assertEquals(['sources' => [self::FIXTURES_FOLDER.'translatable-short.html.php:2']], $catalogue->getMetadata('translatable-short single-quoted key')); |
Member
There was a problem hiding this comment.
This misses the str_replace(\DIRECTORY_SEPARATOR, '/', __DIR__) that was present in the old test (or an equivalent) because the catalogue metadata always stores paths with / as separator instead of the real path.
That's why the CI fails on Windows.
Contributor
There was a problem hiding this comment.
Indeed, I missed that CI fails on Windows. It's fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first in a series that tend to improve PhpAstExtractor (covering more extractions cases, ease test writting for new cases, etc).
I've worked with @Jean-Beru, @Kazadri and @jprivet-dev in the past few weeks on various new cases to increase the number of "locations" from where the extractor can extract translation keys.
As we were working on my own Symfony fork, I'm opening the PR.
But to be honest my colleague @Jean-Beru did the large majority of the work here. Thanks to him 👏!
To avoid a big PR containing multiple new small features, we need to open and hopefully merge this one first to ease the tests writting for next new Visitors.
NB: I'm not sure to qualify or not this PR as New feature?