[PhpUnitBridge] Skip bootstrap for PHPUnit >=10 #60645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
The part about configuring doctrine deprecations might still be useful. |
HypeMC
force-pushed
the
skip-bootstrap-for-phpunit-gte-10
branch
from
1f84a82 to
36974c3
Compare
Member
Author
|
@stof I've applied the condition only to the parts related to |
xabbuh
approved these changes
Jun 3, 2025
Member
|
Thank you @HypeMC. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 29, 2025
…nsion (HypeMC) This PR was merged into the 7.4 branch. Discussion ---------- [PhpUnitBridge] Move Doctrine deprecations setup to extension | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Follow-up to #60645 The `SymfonyExtension::bootstrap()` method seems like a more appropriate place to configure Doctrine deprecations behavior. With this, once support for PHPUnit <10 i dropped, the `bootstrap.php` file can be completely removed. Commits ------- 173dca6 [PhpUnitBridge] Move Doctrine deprecations setup to extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @wouterj, this will skip the bootstrap file that is automatically required by the bridge's
composer.json.I'm not sure whether to skip the entire file or only the part that registers the
DeprecationErrorHandler.