-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Console][Messenger] Fix: Allow UnrecoverableExceptionInterface to bypass retry in RunCommandMessageHandler
#60507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console][Messenger] Fix: Allow UnrecoverableExceptionInterface to bypass retry in RunCommandMessageHandler
#60507
Conversation
UnrecoverableExceptionInterface to bypass retry in RunCommandMessageHandler
|
Shouldn't we do the same for |
Indeed, I forgot about that one. |
|
I don't think we need to do the same for |
|
@santysisi
|
|
Got it, thanks for the explanation! I'll make that change. 🙌 |
…pass retry in RunCommandMessageHandler Co-authored-by: Kevin Bond <kevinbond@gmail.com>
c726fc0 to
6d550d8
Compare
|
Thank you @santysisi. |
This PR ensures that
UnrecoverableExceptionInterfaceexceptions thrown during the execution of a command viaRunCommandMessageare no longer retried.