Skip to content

Passing more than one Security attribute is not supported #60401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chalasr merged 1 commit into from
May 11, 2025
Merged

Passing more than one Security attribute is not supported #60401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Security/Core/Authorization/TraceableAccessDecisionManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public function decide(TokenInterface $token, array $attributes, mixed $object =
$this->accessDecisionStack[] = $accessDecision;

try {
return $accessDecision->isGranted = $this->manager->decide($token, $attributes, $object, $accessDecision);
return $accessDecision->isGranted = $this->manager->decide($token, $attributes, $object, $accessDecision, $allowMultipleAttributes);
} finally {
$this->strategy = $accessDecision->strategy;
$currentLog = array_pop($this->currentLog);
Expand Down
46 changes: 46 additions & 0 deletions ...ymfony/Component/Security/Core/Tests/Authorization/TraceableAccessDecisionManagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,14 @@

namespace Symfony\Component\Security\Core\Tests\Authorization;

use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Authorization\AccessDecisionManager;
use Symfony\Component\Security\Core\Authorization\AccessDecisionManagerInterface;
use Symfony\Component\Security\Core\Authorization\TraceableAccessDecisionManager;
use Symfony\Component\Security\Core\Authorization\Voter\VoterInterface;
use Symfony\Component\Security\Core\Exception\InvalidArgumentException;
use Symfony\Component\Security\Core\Tests\Fixtures\DummyVoter;

class TraceableAccessDecisionManagerTest extends TestCase
Expand Down Expand Up @@ -276,4 +278,48 @@ public function testCustomAccessDecisionManagerReturnsEmptyStrategy()

$this->assertEquals('-', $adm->getStrategy());
}

public function testThrowsExceptionWhenMultipleAttributesNotAllowed()
{
$accessDecisionManager = new AccessDecisionManager();
$traceableAccessDecisionManager = new TraceableAccessDecisionManager($accessDecisionManager);
/** @var TokenInterface&MockObject $tokenMock */
$tokenMock = $this->createMock(TokenInterface::class);

$this->expectException(InvalidArgumentException::class);
$traceableAccessDecisionManager->decide($tokenMock, ['attr1', 'attr2']);
}

/**
* @dataProvider allowMultipleAttributesProvider
*/
public function testAllowMultipleAttributes(array $attributes, bool $allowMultipleAttributes)
{
$accessDecisionManager = new AccessDecisionManager();
$traceableAccessDecisionManager = new TraceableAccessDecisionManager($accessDecisionManager);
/** @var TokenInterface&MockObject $tokenMock */
$tokenMock = $this->createMock(TokenInterface::class);

$isGranted = $traceableAccessDecisionManager->decide($tokenMock, $attributes, null, null, $allowMultipleAttributes);

$this->assertFalse($isGranted);
}

public function allowMultipleAttributesProvider(): \Generator
{
yield [
['attr1'],
false,
];

yield [
['attr1'],
true,
];

yield [
['attr1', 'attr2', 'attr3'],
true,
];
}
}
Loading