Skip to content

replace expectDeprecation() with expectUserDeprecationMessage() #60149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Apr 6, 2025
Merged

replace expectDeprecation() with expectUserDeprecationMessage() #60149

fabpot merged 1 commit into from
Apr 6, 2025

Conversation

@xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 4, 2025

Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 7.3 milestone Apr 4, 2025
@xabbuh
Copy link
Member Author

xabbuh commented Apr 4, 2025

let's leverage the trait we introduced in #54593 for forward compatibility with PHPUnit 11

yceruto
yceruto approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, thanks!

chalasr
chalasr approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pinging @symfony/mergers @symfony/ux so we all know

@chalasr
Copy link
Member

chalasr commented Apr 4, 2025

Should expectDeprecation() go away at some point?

@stof
Copy link
Member

stof commented Apr 4, 2025

@chalasr it is supported only when using the bridge deprecation reporting feature, and that feature is supported only for PHPUnit 9.6 and older.
when using the native PHPUnit deprecation reporting feature (for PHPUnit 11+, or even 10+ if you don't care about feature parity), you have to use the native PHPUnit API.

@chalasr
Copy link
Member

chalasr commented Apr 4, 2025

Thanks for clarifying @stof

@fabpot
Copy link
Member

fabpot commented Apr 6, 2025

Thank you @xabbuh.

@fabpot fabpot merged commit 8e35dd2 into symfony:7.3 Apr 6, 2025
9 of 11 checks passed
@xabbuh xabbuh deleted the pr-54593 branch April 6, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@yceruto yceruto yceruto approved these changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

@chalasr chalasr chalasr approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees

No one assigned

Labels

Status: Reviewed

Projects

None yet

Milestone

7.3

Development

Successfully merging this pull request may close these issues.

7 participants

@xabbuh @chalasr @stof @fabpot @yceruto @alexandre-daubois @carsonbot