Skip to content

[MonologBridge] Make ConsoleHandler not handle messages at SILENT verbosity #60055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Sep 9, 2025
Merged

[MonologBridge] Make ConsoleHandler not handle messages at SILENT verbosity #60055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Symfony/Bridge/Monolog/Handler/ConsoleHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,8 @@ private function updateLevel(): bool
$verbosity = $this->output->getVerbosity();
if (isset($this->verbosityLevelMap[$verbosity])) {
$this->setLevel($this->verbosityLevelMap[$verbosity]);
} elseif (\defined('\Symfony\Component\Console\Output\OutputInterface::VERBOSITY_SILENT') && OutputInterface::VERBOSITY_SILENT === $verbosity) {
return false;
} else {
$this->setLevel(Level::Debug);
}
Expand Down
52 changes: 52 additions & 0 deletions src/Symfony/Bridge/Monolog/Tests/Handler/ConsoleHandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,58 @@ public static function provideVerbosityMappingTests(): array
];
}

/**
* @dataProvider provideHandleOrBubbleSilentTests
*/
public function testHandleOrBubbleSilent(int $verbosity, Level $level, bool $isHandling, bool $isWriting, array $map = [])
{
$output = $this->createMock(OutputInterface::class);
$output
->expects($this->atLeastOnce())
->method('getVerbosity')
->willReturn($verbosity)
;
$handler = new ConsoleHandler($output, false, $map);
$this->assertSame($isHandling, $handler->isHandling(RecordFactory::create($level)), '->isHandling returns correct value depending on console verbosity and log level');

// check that the handler actually outputs the record if it handles it at verbosity above SILENT
$levelName = Logger::getLevelName($level);
$levelName = \sprintf('%-9s', $levelName);

$realOutput = $this->getMockBuilder(Output::class)->onlyMethods(['doWrite'])->getMock();
$realOutput->setVerbosity($verbosity);
$log = "16:21:54 $levelName [app] My info message\n";
$realOutput
->expects($isWriting ? $this->once() : $this->never())
->method('doWrite')
->with($log, false);
$handler = new ConsoleHandler($realOutput, false, $map);

$infoRecord = RecordFactory::create($level, 'My info message', 'app', datetime: new \DateTimeImmutable('2013-05-29 16:21:54'));
$this->assertSame($isHandling, $handler->handle($infoRecord), 'The handler bubbled correctly when it did not output the message.');
}

public static function provideHandleOrBubbleSilentTests(): array
{
// The VERBOSITY_SILENT const is not defined for Console below 7.2, but in that case, the code behaves as before
if (!\defined('\Symfony\Component\Console\Output\OutputInterface::VERBOSITY_SILENT')) {
return [
[OutputInterface::VERBOSITY_NORMAL, Level::Warning, true, true],
[OutputInterface::VERBOSITY_NORMAL, Level::Info, false, false],
];
}

return [
[OutputInterface::VERBOSITY_SILENT, Level::Warning, false, false],
[OutputInterface::VERBOSITY_NORMAL, Level::Warning, true, true],
[OutputInterface::VERBOSITY_NORMAL, Level::Info, false, false],
[OutputInterface::VERBOSITY_SILENT, Level::Warning, true, false, [OutputInterface::VERBOSITY_SILENT => Level::Warning]],
[OutputInterface::VERBOSITY_SILENT, Level::Warning, false, false, [OutputInterface::VERBOSITY_SILENT => Level::Error]],
[OutputInterface::VERBOSITY_SILENT, Level::Emergency, false, false],
[OutputInterface::VERBOSITY_SILENT, Level::Emergency, true, false, [OutputInterface::VERBOSITY_SILENT => Level::Emergency]],
];
}

public function testVerbosityChanged()
{
$output = $this->createMock(OutputInterface::class);
Expand Down
Loading