chore: PHP CS Fixer fixes #59972
Merged
chore: PHP CS Fixer fixes #59972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
7.3_cs_fixes
branch
from
4a2d99b to
f63edc5
Compare
Member
|
Thank you @keradus. |
xabbuh
reviewed
Mar 18, 2025
| use Symfony\Component\Clock\Clock; | ||
| use Symfony\Component\Clock\ClockInterface; | ||
| use Symfony\Component\Clock\MockClock; | ||
|
|
Member
There was a problem hiding this comment.
Is it intended that this (and the following changes) partially reverts #59939?
Member
Author
There was a problem hiding this comment.
Could be some semi-conflicting rule when all needs to be applied to get final outcome.
Right now there is still lot of conflict between config and actually used style and I need to apply rule one by one. But it's only ~50 remaining issues to get clear state, then we will be able to apply whole config and stabilize the piece of code touched by multiple rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with love by PHP Coding Standards Fixer