[Security] Merge UserAuthorizationCheckerInterface into AuthorizationCheckerInterface
#59793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
is-granted-for-user
branch
2 times, most recently
from
dda6575 to
d4a5ea2
Compare
nicolas-grekas
force-pushed
the
is-granted-for-user
branch
from
d4a5ea2 to
b017145
Compare
OskarStark
changed the title
UserAuthorizationCheckerInterface into AuthorizationCheckerInterface
src/Symfony/Component/Security/Core/Authorization/UserAuthorizationCheckerInterface.php
Show resolved
Hide resolved
Member
Author
|
I'm going to submit again with a different approach. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #48142 which was merged recently into 7.3
Having
UserAuthorizationCheckerInterfaceseparate fromAuthorizationCheckerInterfacedoesn't make sense to me.It makes things confusing IMHO, as in "which interface should I implement?"
Of course,
AccessDecisionManagerInterfaceis the central point, but still, I don't see how a separateUserAuthorizationCheckerInterfaceis useful here.The PR also fixes a few issues found in tests and replaces the internal
UserAuthorizationCheckerTokenby an anonymous class.