[Notifier] [Bluesky] Return the record CID as additional info #59789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
alexandre-daubois
approved these changes
Feb 17, 2025
fabpot
approved these changes
Feb 17, 2025
Member
|
This should maybe be done in 7.2 as well (so that people that were using it already can still access it?). |
nicolas-grekas
approved these changes
Feb 17, 2025
src/Symfony/Component/Notifier/Bridge/Bluesky/BlueskyTransport.php
Outdated
Show resolved
Hide resolved
Member
@fabpot the info array is supported since 7.3 |
Member
low-deps failure highlight a missing bump in the deps of the bridge ;) |
OskarStark
reviewed
Feb 17, 2025
nicolas-grekas
force-pushed
the
bluesky_cid
branch
from
8fd987f to
85a073e
Compare
Member
|
Thank you @javiereguiluz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Bluesky API operations (like replies and quotes) require "strong references", which is the combination of the
uriand thecid(See https://docs.bsky.app/docs/advanced-guides/posts#replies-quote-posts-and-embeds).After the changes made in #59742, we should also return the
cidas additional info.