Enable JSON_PRESERVE_ZERO_FRACTION in jsonRequest method
#59769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.2". Cheers! Carsonbot |
raffaelecarelle
changed the title
raffaelecarelle
changed the title
JSON_PRESERVE_ZERO_FRACTION in jsonRequest method
raffaelecarelle
force-pushed
the
fix-preserve-zero-fraction
branch
from
961c9ae to
b8fcd13
Compare
Member
|
this needs a regression tests (which would also help understand which issue is being fixed) |
Contributor
Author
test added |
Contributor
|
Will be cast to int 0? Or do you mean cast to int 10 in the pr description? |
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
I suppose we should merge this in 6.4
nicolas-grekas
approved these changes
Feb 13, 2025
carsonbot
changed the title
JSON_PRESERVE_ZERO_FRACTION in jsonRequest methodJSON_PRESERVE_ZERO_FRACTION in jsonRequest method
Contributor
Author
10, sorry. |
OskarStark
approved these changes
Feb 13, 2025
mtarld
approved these changes
Feb 14, 2025
fabpot
approved these changes
Feb 14, 2025
fabpot
requested review from
chalasr,
dunglas,
jderusse,
lyrixx,
xabbuh and
yceruto
as code owners
fabpot
force-pushed
the
fix-preserve-zero-fraction
branch
from
b066b65 to
535953e
Compare
Member
|
Thank you @raffaelecarelle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the jsonRequest method to use JSON_PRESERVE_ZERO_FRACTION when encoding parameters.
This avoid unintended cast to int.
Test case:
"cost" will be cast to int
10