Skip to content

[TypeInfo] simplify test #59448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Jan 9, 2025
Merged

[TypeInfo] simplify test #59448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/Symfony/Component/TypeInfo/Tests/Type/CollectionTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,6 @@ public function testAccepts()

$this->assertTrue($type->accepts(new \ArrayObject([1 => true])));
$this->assertFalse($type->accepts(new \ArrayObject(['foo' => true])));

$type = new CollectionType(Type::generic(Type::builtin(TypeIdentifier::ITERABLE), Type::int(), Type::bool()));
Copy link
Member Author

@xabbuh xabbuh Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit confused when reading this test added in #59291 as I thought this would be a new test case but it actually seems to be the same as defined on line 118 /cc @mtarld


$this->assertTrue($type->accepts(new \ArrayObject([0 => true, 1 => false])));
$this->assertFalse($type->accepts(new \ArrayObject([0 => true, 1 => 'string'])));
}
Expand Down