Skip to content

[DomCrawler] Make ChoiceFormField::isDisabled return true for unchecked disabled checkboxes #59399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Jan 22, 2025
Merged

[DomCrawler] Make ChoiceFormField::isDisabled return true for unchecked disabled checkboxes #59399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Symfony/Component/DomCrawler/Field/ChoiceFormField.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ public function hasValue(): bool
*/
public function isDisabled(): bool
{
if ('checkbox' === $this->type) {
return parent::isDisabled();
}

if (parent::isDisabled() && 'select' === $this->type) {
return true;
}
Expand Down
11 changes: 11 additions & 0 deletions src/Symfony/Component/DomCrawler/Tests/Field/ChoiceFormFieldTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,17 @@ public function testCheckboxWithEmptyBooleanAttribute()
$this->assertEquals('foo', $field->getValue());
}

public function testCheckboxIsDisabled()
{
$node = $this->createNode('input', '', ['type' => 'checkbox', 'name' => 'name', 'disabled' => '']);
$field = new ChoiceFormField($node);

$this->assertTrue($field->isDisabled(), '->isDisabled() returns true when the checkbox is disabled, even if it is not checked');

$field->tick();
$this->assertTrue($field->isDisabled(), '->isDisabled() returns true when the checkbox is disabled, even if it is checked');
}

public function testTick()
{
$node = $this->createSelectNode(['foo' => false, 'bar' => false]);
Expand Down