-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[PropertyInfo] Remove @internal from PropertyReadInfo and PropertyWriteInfo
#59304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PropertyInfo] Remove @internal from PropertyReadInfo and PropertyWriteInfo
#59304
Conversation
Guarrakesh
commented
Dec 26, 2024
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #58988 |
| License | MIT |
… no static-analysis errors
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
This comment was marked as outdated.
This comment was marked as outdated.
@internal from
@internal from @internal from PropertyReadInfo and PropertyWriteInfo
|
friendly ping @mtarld |
@internal from PropertyReadInfo and PropertyWriteInfo@internal from PropertyReadInfo and PropertyWriteInfo
|
Thank you @Guarrakesh. |