Skip to content

Conversation

@Rindula
Copy link
Contributor

@Rindula Rindula commented Dec 2, 2024

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #59067
License MIT

@Rindula Rindula requested a review from chalasr as a code owner December 2, 2024 13:53
@carsonbot carsonbot added this to the 6.4 milestone Dec 2, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@xabbuh xabbuh added the Console label Dec 2, 2024
@carsonbot carsonbot changed the title Fix division by 0 error [Console] Fix division by 0 error Dec 2, 2024
@fabpot fabpot force-pushed the fix/progressbar-division-by-0-59067 branch from 4652e81 to ee400b0 Compare December 6, 2024 14:10
@fabpot
Copy link
Member

fabpot commented Dec 6, 2024

Thank you @Rindula.

@fabpot fabpot merged commit 51d824a into symfony:6.4 Dec 6, 2024
7 of 11 checks passed
@Rindula Rindula deleted the fix/progressbar-division-by-0-59067 branch December 6, 2024 14:27
@fabpot fabpot mentioned this pull request Dec 11, 2024
This was referenced Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants