-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[HttpClient] Add IPv6 support to NativeHttpClient
#59068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
nicolas-grekas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for starting this!
|
@nicolas-grekas Shall we go ahead with the merge or something else needs to be fixed? |
fb75acc to
44a7a58
Compare
|
Thank you @dmitrii-baranov-tg. |
NativeHttpClient

At the moment,
NativeHttpClientworks only with IPv4 because of the way it does DNS resolution.But by taking inspiration from DNS resolution in
NoPrivateNetworkHttpClient, we are able to make it IPv6 compatible.