[VarDumper] Add casters for object-converted resources #59035

alexandre-daubois · 2024-11-29T10:24:51Z

Q	A
Branch?	7.3
Bug fix?	no
New feature?	yes
Deprecations?	yes
Issues	-
License	MIT

This PR makes up for the backlog of resources transformed into objects in the latest versions of PHP.

✅ Support added (or already existing with an update in AbstractCloner):

ext-curl
- CurlMultiHandle: no information to gather
ext-openssl
- OpenSSLCertificateSigningRequest
- OpenSSLAsymmetricKey
ext-finfo
- No information to gather
ext-sqlite3
- Sqlite3Result
ext-sockets
- Sockets (to rebase on [VarDumper] Add caster for Socket instances #59026)
ext-pgsql
- PgSql\Lob
- PgSql\Connection
- PgSql\Result

⚠️ Remaining classes I couldn't test/find enough info yet (introduced in PHP 8.4):

Odbc\Connection
Odbc\Result
Soap\Url
Soap\Sdl

nicolas-grekas

tedious topic, thanks for working on it

src/Symfony/Component/VarDumper/Caster/CurlCaster.php

src/Symfony/Component/VarDumper/Caster/OpenSslCaster.php

src/Symfony/Component/VarDumper/Caster/CurlCaster.php

src/Symfony/Component/VarDumper/Cloner/AbstractCloner.php

src/Symfony/Component/VarDumper/Caster/DbaCaster.php

src/Symfony/Component/VarDumper/Caster/SocketCaster.php

src/Symfony/Component/VarDumper/Caster/OpenSslCaster.php

src/Symfony/Component/VarDumper/Caster/SocketCaster.php

src/Symfony/Component/VarDumper/Caster/CurlCaster.php

src/Symfony/Component/VarDumper/Caster/OpenSslCaster.php

src/Symfony/Component/VarDumper/Caster/SocketCaster.php

src/Symfony/Component/VarDumper/Caster/SqliteCaster.php

src/Symfony/Component/VarDumper/Caster/ResourceCaster.php

src/Symfony/Component/VarDumper/Caster/DbaCaster.php

src/Symfony/Component/VarDumper/Caster/ResourceCaster.php

alexandre-daubois · 2024-11-29T12:41:11Z

Revamped the PR, so most things are still in ResourceCaster now. The regression in PHP has been reported to php/php-src#16990, and most casters now "simply" map infos to $a.

src/Symfony/Component/VarDumper/Caster/ResourceCaster.php

nicolas-grekas

@internal since 7.3 👍

src/Symfony/Component/VarDumper/Caster/SqliteCaster.php

src/Symfony/Component/VarDumper/Caster/ResourceCaster.php

src/Symfony/Component/VarDumper/Caster/SocketCaster.php

alexandre-daubois · 2024-11-29T14:11:40Z

Marked all casters as internal and added UPGRADE-7.3.md.

src/Symfony/Component/VarDumper/Caster/SocketCaster.php

alexandre-daubois · 2024-11-29T15:45:28Z

Solved by silencing socket_atmark() in the case it cannot be applied on the given socket.

alexandre-daubois · 2024-12-03T08:42:05Z

The dba_list() regression fix will be released in PHP 8.4.2:

dba_list() is now zero-indexed instead of using resource ids php/php-src#16990

This PR was merged into the 6.4 branch. Discussion ---------- Add CI job for PHP 8.5 | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Enables PHP 8.5 nightlies on the CI. What motivated this early addition is the continuous effort of converting resources to actual classes. PHP 8.5 already embeds features like https://wiki.php.net/rfc/directory-opaque-object, which could already be handled in PRs such as #59035. Also we'll be able to fix future deprecations as soon as they appear during the next year. Commits ------- 15d56bb Add an experimental CI job for PHP 8.5

alexandre-daubois · 2025-01-03T08:33:03Z

src/Symfony/Component/VarDumper/Caster/ResourceCaster.php

+     */
+    public static function castDba(mixed $dba, array $a, Stub $stub, bool $isNested): array
    {
+        if (\PHP_VERSION_ID < 80402 && !\is_resource($dba)) {


The fix was shipped with PHP 8.4.2.

src/Symfony/Component/VarDumper/Caster/Caster.php

UPGRADE-7.3.md

src/Symfony/Component/VarDumper/CHANGELOG.md

nicolas-grekas · 2025-01-07T11:17:58Z

src/Symfony/Component/VarDumper/Caster/GdCaster.php

+    public static function castGd(\GdImage $gd, array $a, Stub $stub, bool $isNested): array
+    {
+        $a['size'] = imagesx($gd).'x'.imagesy($gd);
+        $a['trueColor'] = imageistruecolor($gd);


don't these miss the virtual prefix?

Virtual prefixes weren't present before the refactoring, but I'm fine adding them, it makes sense

they weren't present because resource's properties are always virtual
now that we deal with objects, we have to make the virtual explicitly

src/Symfony/Component/VarDumper/Caster/OpenSSLCaster.php

src/Symfony/Component/VarDumper/Caster/ResourceCaster.php

nicolas-grekas · 2025-01-09T16:35:45Z

Thank you @alexandre-daubois.

This PR was squashed before being merged into the 8.0 branch. Discussion ---------- [VarDumper] Remove deprecated resource casters | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | Follows #59035, needs #60810 + #60811 | License | MIT Commits ------- f6fb66f [VarDumper] Remove deprecated resource casters

symfony#59026 and symfony#59035 was worked on in parallel, which resulted in both PRs adding the entry.

…mttsch) This PR was merged into the 7.3 branch. Discussion ---------- [VarDumper] Remove duplicate default caster for Socket #59026 and #59035 was worked on in parallel, which resulted in both PRs adding the entry. | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- 90b33c3 [VarDumper] Remove duplicate default caster for Socket

carsonbot added Status: Needs Review Feature labels Nov 29, 2024

carsonbot added this to the 7.3 milestone Nov 29, 2024

alexandre-daubois force-pushed the casters-resources branch from 13e4077 to 1ff8865 Compare November 29, 2024 10:29

nicolas-grekas reviewed Nov 29, 2024

View reviewed changes

stof reviewed Nov 29, 2024

View reviewed changes

alexandre-daubois mentioned this pull request Nov 29, 2024

dba_list() is now zero-indexed instead of using resource ids php/php-src#16990

Closed

alexandre-daubois force-pushed the casters-resources branch from 7096471 to 24c00c5 Compare November 29, 2024 12:34

alexandre-daubois commented Nov 29, 2024

View reviewed changes

src/Symfony/Component/VarDumper/Caster/ResourceCaster.php Show resolved Hide resolved

alexandre-daubois force-pushed the casters-resources branch 3 times, most recently from ed8fdf2 to d382421 Compare November 29, 2024 12:41

alexandre-daubois force-pushed the casters-resources branch 3 times, most recently from 9830222 to 8ec4800 Compare November 29, 2024 12:51

stof reviewed Nov 29, 2024

View reviewed changes

src/Symfony/Component/VarDumper/Caster/ResourceCaster.php Outdated Show resolved Hide resolved

nicolas-grekas reviewed Nov 29, 2024

View reviewed changes

alexandre-daubois force-pushed the casters-resources branch 3 times, most recently from 34d936d to d0b95fc Compare November 29, 2024 14:10

nicolas-grekas reviewed Nov 29, 2024

View reviewed changes

src/Symfony/Component/VarDumper/Caster/SocketCaster.php Outdated Show resolved Hide resolved

alexandre-daubois force-pushed the casters-resources branch 4 times, most recently from 5cf62d8 to 27a573b Compare November 29, 2024 15:15

nicolas-grekas reviewed Nov 29, 2024

View reviewed changes

src/Symfony/Component/VarDumper/Caster/SocketCaster.php Show resolved Hide resolved

alexandre-daubois force-pushed the casters-resources branch 2 times, most recently from 4952bc6 to 7ea55ce Compare November 29, 2024 15:39

alexandre-daubois force-pushed the casters-resources branch from 7ea55ce to afbb31e Compare November 29, 2024 15:42

alexandre-daubois force-pushed the casters-resources branch 3 times, most recently from ec86ba0 to 9d65675 Compare December 2, 2024 09:25

alexandre-daubois mentioned this pull request Dec 4, 2024

Add CI job for PHP 8.5 #59090

Merged

alexandre-daubois force-pushed the casters-resources branch from 9d65675 to 94aa998 Compare December 6, 2024 13:37

alexandre-daubois commented Jan 3, 2025

View reviewed changes

alexandre-daubois force-pushed the casters-resources branch 2 times, most recently from 392eb5a to ece56db Compare January 7, 2025 11:12

nicolas-grekas reviewed Jan 7, 2025

View reviewed changes

nicolas-grekas added the VarDumper label Jan 7, 2025

carsonbot changed the title ~~Add casters for object-converted resources~~ [VarDumper] Add casters for object-converted resources Jan 7, 2025

alexandre-daubois force-pushed the casters-resources branch 2 times, most recently from 48619eb to 8c99b6a Compare January 7, 2025 12:53

[VarDumper] Add casters for object-converted resources

7be6483

nicolas-grekas force-pushed the casters-resources branch from 8c99b6a to 7be6483 Compare January 9, 2025 16:35

nicolas-grekas merged commit c98cfb6 into symfony:7.3 Jan 9, 2025
10 of 11 checks passed

alexandre-daubois deleted the casters-resources branch January 9, 2025 16:38

fabpot mentioned this pull request May 2, 2025

Release v7.3.0-BETA1 #60327

Merged

derrabus mentioned this pull request Jun 17, 2025

[VarDumper] Remove deprecated resource casters #60812

Merged

mttsch added a commit to mttsch/symfony that referenced this pull request Jun 23, 2025

[VarDumper] Remove duplicate default caster for Socket

90b33c3

symfony#59026 and symfony#59035 was worked on in parallel, which resulted in both PRs adding the entry.

mttsch mentioned this pull request Jun 23, 2025

[VarDumper] Remove duplicate default caster for Socket #60881

Merged

Uh oh!

[VarDumper] Add casters for object-converted resources #59035

[VarDumper] Add casters for object-converted resources #59035

Uh oh!

Conversation

alexandre-daubois commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolas-grekas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexandre-daubois commented Nov 29, 2024

Uh oh!

Uh oh!

nicolas-grekas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexandre-daubois commented Nov 29, 2024

Uh oh!

Uh oh!

Uh oh!

alexandre-daubois commented Nov 29, 2024

Uh oh!

alexandre-daubois commented Dec 3, 2024

Uh oh!

alexandre-daubois Jan 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nicolas-grekas Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

alexandre-daubois Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nicolas-grekas commented Jan 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alexandre-daubois commented Nov 29, 2024 •

edited

Loading

alexandre-daubois Jan 7, 2025 •

edited

Loading