[Process] On Windows, don't rely on the OS to find executables #58710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
approved these changes
Oct 30, 2024
Seldaek
reviewed
Oct 30, 2024
Member
|
Also how about patching this on 5.4+ as bugfix? |
nicolas-grekas
force-pushed
the
process-safer
branch
from
7f30c50 to
05a5cd8
Compare
Member
Author
Would work for me, this is welcomed hardening I think for 5.4 also. Any other opinion? |
Member
|
Not sure if shipping this with a patch release is a good idea. This would break application that rely on the current behaviour. |
nicolas-grekas
force-pushed
the
process-safer
branch
4 times, most recently
from
3732d2b to
62d7067
Compare
nicolas-grekas
force-pushed
the
process-safer
branch
from
62d7067 to
b35a7d4
Compare
Member
Author
|
PR ready, with tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting part of composer/composer#12180 here:
On Windows, when searching for an executable, the OS always looks at the current directory before using the PATH variable. This makes it easier than desired to hijack executables. Unix-like OSes don't have this issue.
This PR proposes to rely on ExecutableFinder instead.