[PropertyInfo][Serializer] Fix default groups #58656
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
mtarld
force-pushed
the
fix/default-groups
branch
from
b65a425 to
62f0ced
Compare
Member
|
Given the attached patch enlarges the public API to fix a BC break introduced in 7.1 6 months ago, I wonder if we shouldn't just revert that feature entirely on 7.1 to reintroduce it on 7.3 the way we want it to be. |
Contributor
Author
|
Agreed, I'd rather just revert the feature. It'll be cleaner and easier to introduce in 7.3. |
fabpot
added a commit
that referenced
this pull request
Nov 9, 2024
This PR was merged into the 7.1 branch. Discussion ---------- [Serializer] Revert Default groups | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #58576, Fix #57350 | License | MIT When introduced in #51514, the behavior of group selection was wrong and introduced BC breaks (see the two related issues). This PR reverts this introduction so that they can be added properly in 7.3 (see #58656). Commits ------- ab3220f [Serializer] Revert default groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When introduced in #51514, the behavior of group selection was wrong and introduced BC breaks (see the two related issues).
This PR resolves them by making that behavior opt-in, hidden behind an
enable_default_groupscontext value.Plus, this PR handles (when opted-in) default groups as they should have been handled in the first place.
Let's say we have the following class:
The
SerializerExtractorwill return properties:null,*,[]noGroup,customGroup,defaultGroup,classGroupcustomcustomGroupDefault,Foo,[]noGroup,defaultGroup,classGroupThe
AbstractNormalizerwill allow attributes:null,[],*noGroup,customGroup,defaultGroup,classGroupcustomcustomGroupDefault,FoonoGroup,defaultGroup,classGroupThe
MetadataAwareNameConverterwill allow attributes:null,[]noGroup,defaultGroup,classGroup*noGroup,customGroup,defaultGroup,classGroupcustomcustomGroupDefault,FoodefaultGroup,classGroupOn the contrary to
SerializerExtractorandAbstractNormalizer,noGroupis not included when any group is specified, andcustomGroupis not included when no group is specified)Another PR should be created in 7.3 in order to deprecate not setting the
enable_default_groupscontext value, as it will default totruein 8.0.