Remove always true/false occurrences #58600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
requested review from
OskarStark,
chalasr,
welcoMattic,
xabbuh and
yceruto
as code owners
alexandre-daubois
force-pushed
the
remove-always-true-false
branch
from
50595e8 to
622f149
Compare
stof
reviewed
Oct 18, 2024
alexandre-daubois
force-pushed
the
remove-always-true-false
branch
3 times, most recently
from
783878e to
a1f101e
Compare
xabbuh
reviewed
Oct 21, 2024
...Bundle/SecurityBundle/DependencyInjection/Compiler/ReplaceDecoratedRememberMeHandlerPass.php
Show resolved
Hide resolved
xabbuh
reviewed
Oct 22, 2024
alexandre-daubois
force-pushed
the
remove-always-true-false
branch
from
a1f101e to
66809df
Compare
Member
Author
|
Thanks Wouter for reopening! @xabbuh, I addressed your comments |
xabbuh
approved these changes
Oct 22, 2024
alexandre-daubois
force-pushed
the
remove-always-true-false
branch
from
66809df to
6980384
Compare
Member
|
Thank you @alexandre-daubois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most occurrences are surely artifact of when PHP allowed less typing.