[Doctrine][Messenger] Oracle sequences are suffixed with _seq
#58557
Conversation
|
Hey! Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4, and 7.1 for bug fixes". Cheers! Carsonbot |
carsonbot
changed the title
devloop42
changed the title
alexandre-daubois
left a comment
alexandre-daubois
left a comment
There was a problem hiding this comment.
Could this be covered by tests to avoid regressions?
| // We need to create a sequence for Oracle and set the id column to get the correct nextval | ||
| if ($this->driverConnection->getDatabasePlatform() instanceof OraclePlatform) { | ||
| $idColumn->setDefault('seq_'.$this->configuration['table_name'].'.nextval'); | ||
| $idColumn->setDefault($this->configuration['table_name'].'_seq'.'.nextval'); |
There was a problem hiding this comment.
| $idColumn->setDefault($this->configuration['table_name'].'_seq'.'.nextval'); | |
| $idColumn->setDefault($this->configuration['table_name'].'_seq.nextval'); |
There was a problem hiding this comment.
@alexandre-daubois : I updated that portion of code for consistency.
@rjd22 : Is this if block really needed as messenger in it's auto config process already create a sequence and trigger in case of id not specified ?
There was a problem hiding this comment.
Yes, for Oracle installations the default block is needed. Else the field won't use the sequence on some installations.
OskarStark
changed the title
_seq
devloop42
force-pushed
the
fix-oracle-sequence-name
branch
from
882e17a to
18eeb64
Compare
|
@xabbuh Since you looked at mine can you take a look at this one? It looks good to me. If we merge this before the next release we avoid a breaking change. |
carsonbot
changed the title
_seq_seq
fabpot
force-pushed
the
fix-oracle-sequence-name
branch
from
18eeb64 to
6a17c04
Compare
|
Thank you @devloop42. |
7 participants
Generated sequences, by doctrine or in this case by the auto_setup of messenger, are suffixed with
_seq.