[HtmlSanitizer] Fix force_attributes not replacing existing attribute in initial data
#58547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Oct 22, 2024
chalasr
requested changes
Oct 22, 2024
Member
chalasr
left a comment
chalasr
left a comment
There was a problem hiding this comment.
Adding an optional argument is for 7.x
Contributor
Author
|
Indeed thanks for the catch! If that's good for you I'll handle it using func_get_args to fix the issue on 6.4 (it's a real bug, I think it's worth it) |
Member
|
Node is a final class, so it can add the argument directly (as there is no issue regarding keeping BC for child classes overriding the method) |
|
Hi, to help on this issue, is there something to change to allow merge for 6.4 ? |
|
Hello, small up on this PR, i really think this needs to be fix to improve sanitized content security I'm uncertain if the |
stof
approved these changes
Feb 13, 2025
OskarStark
changed the title
force_attributes not replacing existing attribute in initial data
Member
|
Thank you @tgalopin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the override of an existing attribute value.