Skip to content

[Notifier] Add LINE Bot bridge #58527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Oct 14, 2024
Merged

[Notifier] Add LINE Bot bridge #58527

fabpot merged 1 commit into from
Oct 14, 2024

Conversation

@pan93412
Copy link
Contributor

@pan93412 pan93412 commented Oct 10, 2024 •
edited
Loading

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #58474
License MIT

It should be worked as what LINE Notify used to do:

LINE Bot demo

@pan93412 pan93412 requested a review from OskarStark as a code owner October 10, 2024 10:09
@carsonbot
Copy link

carsonbot commented Oct 10, 2024

Hey!

Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch "7.2 for features / 5.4, 6.4, and 7.1 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 7.2 milestone Oct 10, 2024
OskarStark
OskarStark reviewed Oct 10, 2024
View reviewed changes
@pan93412 pan93412 requested a review from OskarStark October 10, 2024 10:20
@pan93412 pan93412 force-pushed the notifier/add-line-bot-as-bridge branch 2 times, most recently from 0ba498d to 10c7b41 Compare October 10, 2024 10:28
OskarStark
OskarStark reviewed Oct 10, 2024
View reviewed changes
@pan93412 pan93412 force-pushed the notifier/add-line-bot-as-bridge branch 2 times, most recently from 37ec351 to 8da4731 Compare October 10, 2024 10:49
@pan93412 pan93412 requested a review from OskarStark October 10, 2024 10:49
@pan93412
Copy link
Contributor Author

pan93412 commented Oct 10, 2024

@OskarStark By the way, would you mind to clean up the labels? It might be related to the first description content of PR.

Also, can I safely ignore the CI failure for Verify Packages? It seems that no bridge packages should be replaced.

@pan93412 pan93412 force-pushed the notifier/add-line-bot-as-bridge branch from 8da4731 to 1ed556c Compare October 10, 2024 13:53
@pan93412 pan93412 mentioned this pull request Oct 10, 2024
Closed
OskarStark
OskarStark reviewed Oct 10, 2024
View reviewed changes
@pan93412 pan93412 requested a review from OskarStark October 11, 2024 01:34
@OskarStark
Copy link
Contributor

OskarStark commented Oct 11, 2024

Can you please add a docs and a recipes PR, like done for the other bridges? Thanks

@pan93412 pan93412 mentioned this pull request Oct 11, 2024
Merged
@pan93412
Copy link
Contributor Author

pan93412 commented Oct 11, 2024 •
edited by OskarStark
Loading

@OskarStark done:

@OskarStark
Copy link
Contributor

OskarStark commented Oct 11, 2024

Thanks

OskarStark
OskarStark approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good after my comments

fabpot
fabpot requested changes Oct 13, 2024
View reviewed changes
@pan93412 pan93412 force-pushed the notifier/add-line-bot-as-bridge branch from dda58cf to b8cb8b3 Compare October 14, 2024 01:10
@pan93412
Copy link
Contributor Author

pan93412 commented Oct 14, 2024

Commits are also rebased to the latest 7.2 branch.

@pan93412 pan93412 requested review from OskarStark and fabpot October 14, 2024 01:11
@pan93412 pan93412 force-pushed the notifier/add-line-bot-as-bridge branch from b8cb8b3 to e982829 Compare October 14, 2024 01:13
fabpot
fabpot requested changes Oct 14, 2024
View reviewed changes
@pan93412 pan93412 requested a review from fabpot October 14, 2024 06:19
@fabpot fabpot force-pushed the notifier/add-line-bot-as-bridge branch from 79fe969 to 4f4742e Compare October 14, 2024 06:22
@fabpot
Copy link
Member

fabpot commented Oct 14, 2024

Thank you @pan93412.

@fabpot fabpot merged commit cb16097 into symfony:7.2 Oct 14, 2024
@fabpot fabpot mentioned this pull request Oct 14, 2024
Closed
@pan93412 pan93412 deleted the notifier/add-line-bot-as-bridge branch October 14, 2024 06:24
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Oct 14, 2024
@javiereguiluz
minor #20317 [Notifier] Add LINE Bot notifier (pan93412)
e463bfb 
This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

[Notifier] Add LINE Bot notifier

Related to symfony/symfony#58527
Closed #20321

Commits
-------

d10abd7 [Notifier] Add LINE Bot notifier
@fabpot fabpot mentioned this pull request Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees

No one assigned

Labels

Feature Notifier Status: Reviewed

Projects

None yet

Milestone

7.2

Development

Successfully merging this pull request may close these issues.

[Notifier] Support LINE Messaging API bridge

5 participants

@pan93412 @carsonbot @OskarStark @fabpot @xabbuh