[Security] Fix serialized object representation in tests #58423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| public function testPayloadFromV4CanBeUnserialized() | ||
| { | ||
| $serialized = 'C:74:"Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken":236:{a:3:{i:0;N;i:1;s:4:"main";i:2;a:5:{i:0;s:2:"sf";i:1;b:1;i:2;a:1:{i:0;O:41:"Symfony\Component\Security\Core\Role\Role":1:{s:47:"Symfony\Component\Security\Core\Role\Role'."\0".'role'."\0".'";s:9:"ROLE_USER";}}i:3;a:0:{}i:4;a:1:{i:0;s:9:"ROLE_USER";}}}}'; |
Member
There was a problem hiding this comment.
I'd rather keep the files but fix the serialized payload, which is incorrect (branch 5.4 I guess):
-"Symfony\Component\Security\Core\Role\Role'."\0".'role'."\0".'"
+"'."\0".'Symfony\Component\Security\Core\Role\Role'."\0".'role"
Member
Author
There was a problem hiding this comment.
Works for me, the deprecation notice is gone. Thanks!
alexandre-daubois
force-pushed
the
legacy-notices
branch
from
f4e1c45 to
f9f3cb5
Compare
alexandre-daubois
changed the title
Member
|
Thank you @alexandre-daubois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LegacyRoleTesttriggers the following error: