Make more data providers static #58323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
requested review from
chalasr,
dunglas and
welcoMattic
as code owners
GromNaN
reviewed
Sep 19, 2024
src/Symfony/Component/Translation/Bridge/Phrase/Tests/PhraseProviderTest.php
Show resolved
Hide resolved
derrabus
force-pushed
the
chore/static-data-providers
branch
from
4de90ef to
6d6955b
Compare
derrabus
added a commit
that referenced
this pull request
Sep 20, 2024
This PR was merged into the 7.1 branch. Discussion ---------- Make more data providers static | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | N/A | License | MIT Follows #58323. This PR fixes all data providers that did not exist in 6.4 yet. Commits ------- 6327224 Make more data providers static
stof
approved these changes
Sep 20, 2024
GromNaN
approved these changes
Sep 20, 2024
alexandre-daubois
approved these changes
Sep 20, 2024
derrabus
force-pushed
the
chore/static-data-providers
branch
from
6d6955b to
c0d5be6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data providers must be public and static in PHPUnit 11.