[VarExporter] Allow reinitializing lazy objects with a new initializer #58129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
ve-reset-lazy
branch
from
e1cf36f to
8fb70c4
Compare
stof
reviewed
Aug 30, 2024
src/Symfony/Component/VarExporter/Tests/Fixtures/LazyGhost/RegularClass.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
ve-reset-lazy
branch
2 times, most recently
from
2e478e3 to
a6da075
Compare
stof
reviewed
Aug 30, 2024
OskarStark
reviewed
Aug 30, 2024
src/Symfony/Component/VarExporter/Tests/Fixtures/LazyGhost/RegularClass.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
ve-reset-lazy
branch
from
a6da075 to
4c1b320
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to call createLazyGhost/Proxy on an existing lazy object is a capability that PHP 8.4 will provide thanks to https://wiki.php.net/rfc/lazy-objects, and that zenstruck/foundry desires also to implement refreshable fixtures. /cc @kbond @nikophil