[Serializer] remove custom CSV escape character from tests #58021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Do we keep one as |
Member
Author
|
none of the tests actually depends on the value of the escape character, not sure if we want to add a new test covering it explicitly |
chalasr
approved these changes
Aug 16, 2024
Member
chalasr
left a comment
chalasr
left a comment
There was a problem hiding this comment.
Should we deprecate the CsvEncoder::ESCAPE_CHAR_KEYcontext key on 7.2?
Member
Member
Author
|
@chalasr I think @alexandre-daubois should have that covered in #57827 |
Member
|
Indeed, I'll address the remaining comment in a couple of days. Thanks for this complementary PR! |
Member
|
Isn't the failing test related? |
Member
Author
|
indeed, fixed |
Member
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Aug 17, 2024
This PR was merged into the 6.4 branch. Discussion ---------- [Serializer] clean up PHP version checks | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT these checks are not needed after merging #58021 up into the `6.4` branch Commits ------- 6e19c0f clean up PHP version checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using custom escape character will be deprecated from PHP 8.4