replace uniqid() with random_bytes() to create identifiers
#57856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jul 28, 2024
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 7.2 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #57588 |
| License | MIT |
derrabus
approved these changes
Jul 28, 2024
OskarStark
changed the title
uniqid() with random_bytes() to create identifiers
fabpot
approved these changes
Jul 29, 2024
Member
|
Thank you @xabbuh. |
TimWolla
reviewed
Jul 29, 2024
| try { | ||
| if ($delayInMs > 0) { // the delay is <= 0 for queued messages | ||
| $id = uniqid('', true); | ||
| $id = bin2hex(random_bytes(4)); |
Contributor
There was a problem hiding this comment.
Note that random_bytes(4) only has 32 bits of entropy, which is less than the previous call to uniqid() with $more_entropy set to true. This should use at least random_bytes(8) for 64 bits of entropy and ideally random_bytes(16) for 128 bits (the latter would result in a slightly longer output of 32 characters instead of 23 for uniqid).
Member
Author
There was a problem hiding this comment.
maybe we should use the initial suggestion from the issue and use a UUID instead (see #57872)
nicolas-grekas
added a commit
that referenced
this pull request
Aug 12, 2024
…() (xabbuh) This PR was merged into the 7.2 branch. Discussion ---------- [Messenger][Notifier] use more entropy with random_bytes() | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | #57856 (comment) | License | MIT Commits ------- 8152a02 use more entropy with random_bytes()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.