[Security] Update web-token/jwt-library version and adjust checker parameters #57796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1 for bug fixes". Cheers! Carsonbot |
carsonbot
changed the title
Member
|
Maybe we should backport #57694. In tests we don't use version 4 of web-token/jwt-library, but since we don't have a conflict rule for it consumers of symfony/security-http can use it and run into the issue this PR is going to fix. |
OskarStark
changed the title
OidcTokenHandler
Member
|
Better back port than conflict to me also. |
Contributor
Author
|
Backport commit done @xabbuh @nicolas-grekas |
thibaut22200
changed the title
OidcTokenHandler
nicolas-grekas
approved these changes
Jul 24, 2024
carsonbot
changed the title
thibaut22200
force-pushed
the
oidc-token-handler-diff-for-checkers
branch
from
f1e656d to
e8ea16b
Compare
thibaut22200
force-pushed
the
oidc-token-handler-diff-for-checkers
branch
2 times, most recently
from
b349c2e to
6009932
Compare
Contributor
Author
|
Oops, fixed @xabbuh |
xabbuh
approved these changes
Jul 25, 2024
fabpot
approved these changes
Jul 26, 2024
fabpot
force-pushed
the
oidc-token-handler-diff-for-checkers
branch
from
6009932 to
536cd72
Compare
Member
|
Thank you @thibaut22200. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test failed on my Ubuntu, and on my Windows is OK. Differences between order in construct of Jose/Component/Checker/...