Skip to content

[Serializer] Raise correct exception in ArrayDenormalizer when called without a nested denormalizer #57646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xabbuh merged 1 commit into from
Jul 17, 2024
Merged

[Serializer] Raise correct exception in ArrayDenormalizer when called without a nested denormalizer #57646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Symfony/Component/Serializer/Normalizer/ArrayDenormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public function getSupportedTypes(?string $format): array
*/
public function denormalize(mixed $data, string $type, ?string $format = null, array $context = []): array
{
if (null === $this->denormalizer) {
if (!isset($this->denormalizer)) {
throw new BadMethodCallException('Please set a denormalizer before calling denormalize()!');
}
if (!\is_array($data)) {
Expand Down Expand Up @@ -72,7 +72,7 @@ public function denormalize(mixed $data, string $type, ?string $format = null, a

public function supportsDenormalization(mixed $data, string $type, ?string $format = null, array $context = []): bool
{
if (null === $this->denormalizer) {
if (!isset($this->denormalizer)) {
throw new BadMethodCallException(sprintf('The nested denormalizer needs to be set to allow "%s()" to be used.', __METHOD__));
}

Expand Down
16 changes: 16 additions & 0 deletions src/Symfony/Component/Serializer/Tests/Normalizer/ArrayDenormalizerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,22 @@ public function testSupportsNoArray()
)
);
}

public function testDenormalizeWithoutDenormalizer()
{
$arrayDenormalizer = new ArrayDenormalizer();

$this->expectException(\BadMethodCallException::class);
$arrayDenormalizer->denormalize([], 'string[]');
}

public function testSupportsDenormalizationWithoutDenormalizer()
{
$arrayDenormalizer = new ArrayDenormalizer();

$this->expectException(\BadMethodCallException::class);
$arrayDenormalizer->supportsDenormalization([], 'string[]');
}
}

class ArrayDummy
Expand Down