[Security][SecurityBundle] Allow passing attributes to passport via Security::login()
#57495
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot
changed the title
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
This looks legit to me but please add tests.
| * @param BadgeInterface[] $badges Optionally, pass some Passport badges to use for the manual login | ||
| * @param array<string, mixed> $attributes Optionally, pass some Passport attributes to use for the manual login |
There was a problem hiding this comment.
not sure why fabbot didn't pick this one
| * @param BadgeInterface[] $badges Optionally, pass some Passport badges to use for the manual login | |
| * @param array<string, mixed> $attributes Optionally, pass some Passport attributes to use for the manual login | |
| * @param BadgeInterface[] $badges Optionally, pass some Passport badges to use for the manual login | |
| * @param array<string, mixed> $attributes Optionally, pass some Passport attributes to use for the manual login |
OskarStark
changed the title
Security::login()
|
@SteNafH Do you plan to finish this PR anytime soon or would you like someone to take over? |
|
Hi @chalasr - This isn't my PR :) It seems you tagged the wrong person |
|
Hey @chalasr it is my pr ;), I have found another way of fixing the problem that made me open this PR in the first place. However I do feel that this is a good feature to have... Sadly I don't have a lot of time on my hands and I would appreciate if someone else would takeover this pr! |
OskarStark
added
the
Help wanted
|
@alexandre-daubois took over in Thanks for your work |
… passport via `Security::login()` (alexandre-daubois) This PR was merged into the 7.2 branch. Discussion ---------- [Security][SecurityBundle] Allow passing attributes to passport via `Security::login()` | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT Supersedes #57495 after the last comment. Commits ------- 73b863c [Security][SecurityBundle] Allow passing attributes to passport via `Security::login()`
6 participants
When using the
Security::login()function it was not possible to set attributes on a passport. My authenticator is trying to get an attribute from a passport hence this PR.