[DoctrineBridge] Test reset with a true manager #57483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Jun 21, 2024
Contributor
Author
|
How can I make high-deps tests pass? 🤔 |
MatTheCat
force-pushed
the
reset-manager-test
branch
2 times, most recently
from
a69f82d to
e5e9457
Compare
MatTheCat
force-pushed
the
reset-manager-test
branch
from
e5e9457 to
79b03db
Compare
xabbuh
approved these changes
Jun 21, 2024
Member
|
Thank you @MatTheCat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that assertions were added to the
AbstractManagerRegistry, theManagerRegistryTestmust register instances ofObjectManagerto avoid tests failing withChanges mostly come from #48484 but the ProxyManager is still used on 5.4, so beware when merging this in 6.4.