[PropertyInfo] Adds static cache to PhpStanExtractor
#54894
Conversation
|
Please target 7.1. We usually don't merge performance improvements into LTS branches. |
src/Symfony/Component/PropertyInfo/Extractor/PhpStanExtractor.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/PropertyInfo/Extractor/PhpStanExtractor.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/PropertyInfo/PhpStan/NameScopeFactory.php
Outdated
Show resolved
Hide resolved
mvhirsch
force-pushed
the
phpstan-extractor
branch
from
978e580 to
767d355
Compare
mvhirsch
requested review from
OskarStark,
chalasr,
jderusse,
kbond,
lyrixx,
welcoMattic,
xabbuh and
yceruto
as code owners
mvhirsch
force-pushed
the
phpstan-extractor
branch
from
4378f20 to
de14980
Compare
|
Shouldn't we now also implement the |
If so, the |
If all we store is class metadata, we don't need a reset IMHO as the leak is upper bounded, and resetting might effect performance of long running kernels for little memory savings in the end. |
| return null; | ||
| } | ||
|
|
||
| $nameScope = $this->contexts[$class.$declaringClass] ??= $this->nameScopeFactory->create($class, $declaringClass); |
There was a problem hiding this comment.
| $nameScope = $this->contexts[$class.$declaringClass] ??= $this->nameScopeFactory->create($class, $declaringClass); | |
| $nameScope = $this->contexts[$class.'/'.$declaringClass] ??= $this->nameScopeFactory->create($class, $declaringClass); |
There was a problem hiding this comment.
would it make sense to move this inside the loop, right before the nested foreach?:
$nameScope ??= $this->contexts[$class.'/'.$declaringClass] ??= $this->nameScopeFactory->create($class, $declaringClass);There was a problem hiding this comment.
would it make sense to move this inside the loop, right before the nested foreach?:
You mean here?
Sounds reasonable to me. It may make sense to skip creating one unless really needed (and since my change is all about re-using a created one, it hardly influences performance).
src/Symfony/Component/PropertyInfo/Extractor/PhpStanExtractor.php
Outdated
Show resolved
Hide resolved
|
Thank you @mvhirsch. |
8 participants
I was able to detect a performance penalty when using dozens of traits in even more classes. The
PhpStanExtractorcreates aNameScopeevery time, but afaik this can be cached like inPhpDocExtractor(see #32188).The performance impact is impressive, as it reduces the time needed for my
TestCaseby 30%. See Blackfire profile comparison.