[VarExporter] fix ProxyHelper::generateLazyProxy() when a method returns null
#54850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
fix/allow-null-return-type
branch
2 times, most recently
from
6fd1794 to
330dcc7
Compare
nikophil
commented
May 6, 2024
nikophil
force-pushed
the
fix/allow-null-return-type
branch
from
330dcc7 to
aeecd29
Compare
nikophil
commented
May 6, 2024
nikophil
force-pushed
the
fix/allow-null-return-type
branch
from
aeecd29 to
673bb6b
Compare
nikophil
force-pushed
the
fix/allow-null-return-type
branch
from
673bb6b to
59b3b7a
Compare
Member
|
Can you also please update src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php? It has the same issue (two times) |
nikophil
force-pushed
the
fix/allow-null-return-type
branch
2 times, most recently
from
b3ab90f to
37ba6e7
Compare
nikophil
force-pushed
the
fix/allow-null-return-type
branch
from
37ba6e7 to
0067eab
Compare
src/Symfony/Component/VarDumper/Tests/Fixtures/Php82NullStandaloneReturnType.php
Outdated
Show resolved
Hide resolved
nikophil
force-pushed
the
fix/allow-null-return-type
branch
2 times, most recently
from
0842909 to
23c16c6
Compare
xabbuh
reviewed
May 7, 2024
src/Symfony/Component/VarExporter/Tests/Fixtures/LazyProxy/Php82NullStandaloneReturnType.php
Show resolved
Hide resolved
xabbuh
reviewed
May 7, 2024
src/Symfony/Component/VarDumper/Tests/Fixtures/Php82NullStandaloneReturnType.php
Show resolved
Hide resolved
nikophil
force-pushed
the
fix/allow-null-return-type
branch
from
23c16c6 to
dc083fe
Compare
xabbuh
approved these changes
May 7, 2024
fabpot
approved these changes
May 7, 2024
Member
|
Thank you @nikophil. |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a methods has such a signature:
the method
ProxyHelper::generateLazyProxy()produces a wrong code:This PR fixes this.