[Validator] Accept Stringable in ExecutionContext::build/addViolation()
#54487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
changed the title
Stringable in `ExecutionContext::build/addViolat…Stringable in ExecutionContext::build/addViolation()
Member
|
Just to be sure: this matters only when strict types are enabled, right? Looking at the |
Member
Author
|
Indeed! It works as-is when strict types are disabled. I guess we have to wait for the next major to update the interface, even if it's a bug? |
alexandre-daubois
force-pushed
the
fix-stringable-type
branch
from
394b514 to
edcc2d8
Compare
alexandre-daubois
requested review from
OskarStark,
chalasr,
dunglas,
jderusse,
kbond,
lyrixx,
welcoMattic,
xabbuh and
yceruto
as code owners
Member
|
Ah no sorry, the change was fine for 6.4. |
alexandre-daubois
force-pushed
the
fix-stringable-type
branch
from
edcc2d8 to
394b514
Compare
Member
Author
|
Got back to 6.4. 👍 I think this is something that may be doable with some custom PHPStan rule? I didn't play with this yet, that's an interesting case. I'll try something when I have some time. |
nicolas-grekas
approved these changes
Apr 4, 2024
OskarStark
approved these changes
Apr 5, 2024
fabpot
approved these changes
Apr 5, 2024
Member
|
Thank you @alexandre-daubois. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConstraintViolationBuilderaccepts any stringable. We mentioned this in the doc but it doesn't work as explained in the issue. I thinkbuildViolation()could accept stringable, also given thatExecutionContextInterfacedefines the type asstring|Stringablein the PHPDoc.Same for
addViolation().