Skip to content

Throw TransformationFailedException when there is a null bytes injection #54306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sormes wants to merge 3 commits into from
Closed

Throw TransformationFailedException when there is a null bytes injection #54306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df2c12d
Throw TransformationFailedException when there is a null bytes inject…
sormes Mar 15, 2024
2dd9b21
fix cs
sormes Mar 16, 2024
9b65520
fix cs
sormes Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToStringTransformer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@ public function reverseTransform($value)
throw new TransformationFailedException('Expected a string.');
}

if (str_contains($value, "\0")) {
throw new TransformationFailedException('Null bytes not allowed');
}

$outputTz = new \DateTimeZone($this->outputTimezone);
$dateTime = \DateTime::createFromFormat($this->parseFormat, $value, $outputTz);

Expand Down
13 changes: 13 additions & 0 deletions ...y/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToStringTransformerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,19 @@ public function testReverseTransformEmpty()
$this->assertNull($reverseTransformer->reverseTransform(''));
}

public function testReverseTransformWithNullBytes()
{
$transformer = new DateTimeToStringTransformer();

$nullByte = \chr(0);
$value = '2024-03-15 21:11:00'.$nullByte;

$this->expectException(TransformationFailedException::class);
$this->expectExceptionMessage('Null bytes not allowed');

$transformer->reverseTransform($value);
}

public function testReverseTransformWithDifferentTimezones()
{
$reverseTransformer = new DateTimeToStringTransformer('America/New_York', 'Asia/Hong_Kong', 'Y-m-d H:i:s');
Expand Down