[Process] Fix failing tests causing segfaults #53909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
proc-segfault
branch
from
055e276 to
1a9fe48
Compare
Member
|
This won't work on windows. Hybrid mode ? |
alexandre-daubois
force-pushed
the
proc-segfault
branch
from
1a9fe48 to
942a836
Compare
Member
Author
|
I'm having a look |
alexandre-daubois
force-pushed
the
proc-segfault
branch
from
942a836 to
9a570c1
Compare
alexandre-daubois
force-pushed
the
proc-segfault
branch
from
9a570c1 to
041e178
Compare
Member
Author
|
AppVeyor's green on these tests, red is unrelated |
Member
|
Thank you @alexandre-daubois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some code that triggers segfaults in newer branches (7.x especially). We can achieve the same goal by using some bash script which is lighter and avoid the segfaults. I first tried this fix on 7.x and solved the issue (that does not happen on older branches).