[Serializer] Fix support of plain object types denormalization #52804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersonamuller
changed the title
Contributor
|
Can you please add test case to avoid further regressions? Thank you! |
Contributor
Author
I added a test case |
Contributor
|
friendly ping @mtarld as you are deeply involved in the serializer component, thanks! |
mtarld
reviewed
Dec 1, 2023
Contributor
mtarld
left a comment
mtarld
left a comment
There was a problem hiding this comment.
I'd do instead:
if (Type::BUILTIN_TYPE_OBJECT === $builtinType && null !== $class) {By doing that, it'll fallback to:
if (('is_'.$builtinType)($data)) {And IMHO, it might be better to handle a raw object as a builtin type. WDYT?
Contributor
Author
Makes sense, I have pushed the change. |
When denormalizing properties with a plain `object` type without a class the `ObjectNormalizer` would fail with a `TypeError`.
mtarld
approved these changes
Dec 1, 2023
carsonbot
changed the title
carsonbot
changed the title
Member
|
Thank you @andersonamuller. |
This was referenced Dec 1, 2023
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When denormalizing properties with a plain
objecttype without a class theObjectNormalizerwould fail with aTypeError.