[FrameworkBundle] register the virtual request stack together with common profiling services #52604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
force-pushed
the
issue-52280
branch
2 times, most recently
from
8f2225d to
b8db128
Compare
nicolas-grekas
approved these changes
Nov 17, 2023
Comment on lines
51
to
52
| ->args([service('request_stack')]) | ||
| ->public() |
Member
There was a problem hiding this comment.
Suggested change
| ->args([service('request_stack')]) | |
| ->public() | |
| ->args([service('request_stack')]) | |
| ->public() |
carsonbot
changed the title
fabpot
approved these changes
Nov 18, 2023
…vices The debug.php file is never loaded when the Stopwatch component is not installed. However, the virtual request stack is always valuable as soon as the profiling feature is enabled.
Member
|
Thank you @xabbuh. |
Contributor
|
FYI: I can confirm, that fix works (for me) 👍 I now have working integration tests (which run an actual Symfony application) on Symfony 6.4 and 7.0, using the RC1-packages and |
Member
Author
|
@scheb Thank you very much for testing development versions and providing valuable feedback. This is much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug.php file is never loaded when the Stopwatch component is not installed. However, the virtual request stack is always valuable as soon as the profiling feature is enabled.