Skip to content

[Cache][VarExporter] Fix proxy generation to deal with edgy behaviors of internal classes #52036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Oct 13, 2023
Merged

[Cache][VarExporter] Fix proxy generation to deal with edgy behaviors of internal classes #52036

nicolas-grekas merged 1 commit into from
Oct 13, 2023

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Oct 13, 2023

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #51770, #51679, #51700
License MIT

Instead of #51838

This fixes the issue by not passing default values explicitly when they were not provided during the call to the method.

@carsonbot carsonbot added this to the 6.3 milestone Oct 13, 2023
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 13, 2023
Closed
@nicolas-grekas nicolas-grekas merged commit 21599a4 into symfony:6.3 Oct 13, 2023
@nicolas-grekas nicolas-grekas deleted the cache-proxy branch October 13, 2023 09:35
@fabpot fabpot mentioned this pull request Oct 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug Cache Status: Needs Review VarExporter

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

2 participants

@nicolas-grekas @carsonbot