Skip to content

[FrameworkBundle] Fix calling Kernel::warmUp() when running cache:warmup #51969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Oct 12, 2023
Merged

[FrameworkBundle] Fix calling Kernel::warmUp() when running cache:warmup #51969

nicolas-grekas merged 1 commit into from
Oct 12, 2023

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Oct 10, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT

Maps to

symfony/src/Symfony/Component/HttpKernel/Kernel.php

Lines 581 to 587 in e86d26a

$preload = $this instanceof WarmableInterface ? (array) $this->warmUp($this->container->getParameter('kernel.cache_dir')) : [];
if ($this->container->has('cache_warmer')) {
$preload = array_merge($preload, (array) $this->container->get('cache_warmer')->warmUp($this->container->getParameter('kernel.cache_dir')));
}

@carsonbot carsonbot added this to the 5.4 milestone Oct 10, 2023
HeahDude
HeahDude reviewed Oct 10, 2023
View reviewed changes
@OskarStark OskarStark changed the title [FrameworkBundle] Fix calling Kernel::warmUp() when running cache:warmup [FrameworkBundle] Fix calling Kernel::warmUp() when running cache:warmup Oct 10, 2023
@nicolas-grekas nicolas-grekas merged commit 4290999 into symfony:5.4 Oct 12, 2023
@nicolas-grekas nicolas-grekas deleted the fwb-warm-kernel branch October 16, 2023 20:21
@fabpot fabpot mentioned this pull request Oct 21, 2023
Merged
@fabpot fabpot mentioned this pull request Oct 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HeahDude HeahDude HeahDude left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug FrameworkBundle Status: Needs Review

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-grekas @HeahDude @carsonbot