[WebProfilerBundle] Fix Form profiler toggles #51640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Poke @javiereguiluz :) |
javiereguiluz
approved these changes
Sep 13, 2023
Member
javiereguiluz
left a comment
javiereguiluz
left a comment
There was a problem hiding this comment.
This looks nice to me 👍
Simon, thanks a lot for taking care of fixing and updating this.
stof
reviewed
Sep 13, 2023
| {% if data.errors is defined and data.errors|length > 0 %} | ||
| <div class="errors"> | ||
| <h3> | ||
| <a class="toggle-button" data-toggle-target-id="{{ data.id }}-errors" href="#"> |
Member
There was a problem hiding this comment.
why are you removing this toggle button ?
Member
Author
There was a problem hiding this comment.
This one allowed to toggle the content of the "Errors" tab.
Tab + toggle seem duplicates to me, and i don't see a case where someone would click on the "errors" tab then would want to hide its content (see capture 1)
But i may have missed something. Did you have something in mind ?
fabpot
approved these changes
Sep 13, 2023
Member
|
Thank you @smnandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following: #51621