[WebProfilerBundle] Replace last "old" icon + delete ICONS_LICENCE.txt #51621
Conversation
|
Simon, thanks for this improvement. I like it! About the removal of the previous icon license, I'd say there's no problem. While reviewing this, I found two other occurrences of Would you have some time to try to update those too? If you can't, we can tackle that in another PR. Thanks. |
That's not the same icon: it uses a "Tabler icon but in base64" .. would you like to change it for a "chevron" ? (i rather ask if you did not see) |
|
@smnandre I didn't realize they were different icons. Sorry. In any case, we should probably be consistent and use a chevron in all examples related to expand/collapse elements. Another thing; the current icon in form seem to NOT be working because I always see the |
Don't be @javiereguiluz , i missed it entirely so .. :) Works for me to leave the rest for another PR.. i'm feeling we may raise other questions / needs. |
|
Thank you @smnandre. |
fabpot
force-pushed
the
dx/clean-webprofiler-icons
branch
from
999087a to
584c512
Compare
This PR was merged into the 6.4 branch. Discussion ---------- [WebProfilerBundle] Fix Form profiler toggles | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix | License | MIT Following: #51621 * Reuse the chervron in the filetree * Remove the not-togglin-toggle present on the error zone | before | after | - | - |  |  | Commits ------- 0dbab84 Fix Form profiler toggles
4 participants
Two (related) things in this PR
ICONS_LICENCE.txtfile (as there is no concerned icons remaining, and there is now a LICENCE.txt file in theResources/views/Icon/directory)I targeted the 6.4 branch as there is no BC in code.. but i don't know how to handle a licence change 🤷🏻♂️