[FrameworkBundle] Add --exclude option to the cache:pool:clear command
#51058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatTheCat
force-pushed
the
exclude_pools_from_clearing
branch
from
a9a13cc to
5126d11
Compare
maxbeckers
approved these changes
Jul 21, 2023
MatTheCat
force-pushed
the
exclude_pools_from_clearing
branch
from
5126d11 to
39fe666
Compare
Member
|
Please always rebase, we don't accept PRs with merge commits in their history. |
MatTheCat
force-pushed
the
exclude_pools_from_clearing
branch
from
b3312ea to
fa93e0c
Compare
Contributor
Author
|
Sorry, tried to rebase using GitHub UI but it ended in a merge commit 😅 |
Member
|
We could deprecate |
Contributor
To me this could be done in a separate PR, while this has some implicit drawbacks IMHO, because you could clear more than expected 👎 I would go with this PR as is |
MatTheCat
force-pushed
the
exclude_pools_from_clearing
branch
from
fa93e0c to
21d0348
Compare
Contributor
|
One last proposal from a DX perspective could be to give autocompletion for the possible values? |
fabpot
approved these changes
Oct 11, 2023
Member
|
Thank you @MatTheCat. |
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 11, 2023
…option (MatTheCat) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Cache] Document `cache:pool:clear`’s new `--exclude` option Feature PR * symfony/symfony#51058 Commits ------- cc7ac50 [Cache] Document `cache:pool:clear`’s new `--exclude` option
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now this PR just ignores excluded pools/clearers when they don’t exist or wouldn’t be cleared/run anyways. Not sure what the best DX would be 🤔