[DependencyInjection] Fix fetching lazy non-shared services multiple times with as files true
#50996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
force-pushed
the
fix-fetching-of-lazy-non-shared-services-2
branch
2 times, most recently
from
213940b to
a12184c
Compare
…times with as files true
HypeMC
force-pushed
the
fix-fetching-of-lazy-non-shared-services-2
branch
from
a12184c to
cb434a4
Compare
HypeMC
commented
Jul 16, 2023
Comment on lines
-775
to
+757
| ->register('foo', Foo::class) | ||
| ->register('foo', \Bar\FooLazyClass::class) |
Member
Author
There was a problem hiding this comment.
A minor mistake I made in my original PR, doesn't really change anything, but it makes the test a bit more consistent.
HypeMC
commented
Jul 16, 2023
Comment on lines
+814
to
+817
| $lastDump = array_pop($dumps); | ||
| foreach (array_reverse($dumps) as $dump) { | ||
| eval('?>'.$dump); | ||
| } |
Member
Author
There was a problem hiding this comment.
Is there a better way to do this?
Member
|
Thank you @HypeMC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #50985, fixes case when
as_filesistrue.This particular problem exists only on v6.3 and was introduced in #48469.