[Console] Remove deprecations across the component #50613

alexandre-daubois · 2023-06-09T11:37:56Z

Q	A
Branch?	7.0
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

In short: preparing the component for 7.0 🙂

nicolas-grekas

let's finish existing PRs before opening new ones ;)

src/Symfony/Bridge/Monolog/Command/ServerLogCommand.php

alexandre-daubois · 2023-06-13T15:31:17Z

src/Symfony/Component/Runtime/composer.json

+        "composer/composer": "^2.6",
        "symfony/console": "^6.4|^7.0",
        "symfony/dotenv": "^6.4|^7.0",
+        "symfony/finder": "^6.4",


This is necessary because composer/class-map-generator doesn't support Symfony ^7.0 yet. The highest dep for the Finder must be set to ^6.4 because of this for now.

please send a PR to class-map-generator instead

It has been dealt by @stloyd here, thanks!

I'll revert the change once it's merged.

I was going to update when I saw you updated the file. Thank you! 🙂

src/Symfony/Component/Runtime/composer.json

nicolas-grekas · 2023-06-29T08:40:04Z

src/Symfony/Component/Console/Command/CompleteCommand.php

        try {
-            // "symfony" must be kept for compat with the shell scripts generated by Symfony Console 5.4 - 6.1
-            $version = $input->getOption('symfony') ? '1' : $input->getOption('api-version');
+            $version = $input->getOption('api-version');


What about this one @wouterj? should we keep support for the deprecated flag to provide a smooth transition?
Also, we're missing a deprecation notice if this should be removed in 7.0

This was modified by #46901.

We need to keep the symfony option if we want developers to be able use to bash completion for different projects with different Symfony versions on the same computer. The completion script in symfony/console from 5.4.x to 6.1.x sets the option -S but not -a. If the option is removed, the _complete command will fail.

symfony/src/Symfony/Component/Console/Resources/completion.bash

Line 28 in a6e5b75

local completecmd=("$sf_cmd" "_complete" "--no-interaction" "-sbash" "-c$cword" "-S{{ VERSION }}")

We can fallback to api-version=1 when not specified.

Suggested change

$version = $input->getOption('api-version');

$version = $input->getOption('api-version', 1);

It would be better to make this change in a dedicated PR.

If I understand correctly, here is what you suggest:

Create a PR targeting 6.4 as a new feature, making api-version fallback to 1

Update symfony option deprecation to be removed in 8.0, when 5.4 is EOLed.

I'll take care of this if it is what you meant

I think we should revert this change completely and leave it as-is. Notice the comment says "kept for compat" without deprecating the old one, which is intentional.

Shell completion scripts are global and there is no reason to make life extremely difficult for developers that work on several Symfony versions, some of which are older than 7.0, for the gain of removing these 2 LOC :)

This suits me fine. As you said, these are just 2 lines of code 😄 I reverted this change

Do I have something to do with this?

nicolas-grekas · 2023-06-29T08:40:38Z

src/Symfony/Component/Console/Tests/Command/CommandTest.php

-        $this->assertSame('This is a command I wrote all by myself', $command->getDescription());
-    }
-
-    public function testAttributeOverridesProperty()


this one is not legacy 🤔

That's right, but now that $defaultName and $defaultDescription are removed, it feels irrelevant to me to have this test. I guess this should have been marked as legacy as well when the properties were deprecated? Or maybe am I missing something?

However, I may update this test with a command without the attribute and checking that the getDefaultName() and getDefaultDescription() are null

We should still keep it to ensure no regressions on the topic. (Removing depreciation annotations on the fixture)

That's reverted and updated 👍

nicolas-grekas · 2023-06-30T11:56:30Z

Thank you @alexandre-daubois.

alexandre-daubois requested review from chalasr, xabbuh and yceruto as code owners June 9, 2023 11:37

carsonbot added Status: Needs Review Console Feature labels Jun 9, 2023

carsonbot added this to the 7.0 milestone Jun 9, 2023

alexandre-daubois force-pushed the console-deprecations branch 2 times, most recently from 903ba6a to 171965f Compare June 9, 2023 12:16

nicolas-grekas reviewed Jun 9, 2023

View reviewed changes

src/Symfony/Bridge/Monolog/Command/ServerLogCommand.php Outdated Show resolved Hide resolved

alexandre-daubois force-pushed the console-deprecations branch from 171965f to 740e684 Compare June 13, 2023 15:29

alexandre-daubois changed the title ~~[Console] Remove deprecations and add types across the component~~ [Console] Remove deprecations across the component Jun 13, 2023

alexandre-daubois commented Jun 13, 2023

View reviewed changes

src/Symfony/Component/Runtime/composer.json Show resolved Hide resolved

alexandre-daubois force-pushed the console-deprecations branch 7 times, most recently from 1a9a9f0 to a1854be Compare June 13, 2023 15:52

nicolas-grekas reviewed Jun 29, 2023

View reviewed changes

stloyd mentioned this pull request Jun 29, 2023

Allow to install Symfony Finder v7 composer/class-map-generator#4

Merged

alexandre-daubois force-pushed the console-deprecations branch 6 times, most recently from 36591f1 to 41d1515 Compare June 29, 2023 11:46

alexandre-daubois force-pushed the console-deprecations branch from 41d1515 to 6c89c12 Compare June 30, 2023 09:01

[Console] Remove deprecations across the component

7e81c91

nicolas-grekas force-pushed the console-deprecations branch from 6c89c12 to 7e81c91 Compare June 30, 2023 11:49

nicolas-grekas merged commit 21096e6 into symfony:7.0 Jun 30, 2023

nicolas-grekas mentioned this pull request Jun 30, 2023

[Console] Remove deprecations across the component symfony/symfony-docs#18472

Closed

alexandre-daubois deleted the console-deprecations branch June 30, 2023 11:57

fabpot mentioned this pull request Oct 21, 2023

Release v7.0.0-BETA1 #52224

Merged

	$version = $input->getOption('api-version');
	$version = $input->getOption('api-version', 1);

Uh oh!

[Console] Remove deprecations across the component #50613

[Console] Remove deprecations across the component #50613

Uh oh!

Conversation

alexandre-daubois commented Jun 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolas-grekas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GromNaN Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexandre-daubois Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas commented Jun 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

alexandre-daubois commented Jun 9, 2023 •

edited

Loading

nicolas-grekas left a comment •

edited

Loading

GromNaN Jun 29, 2023 •

edited

Loading

nicolas-grekas Jun 29, 2023 •

edited

Loading

alexandre-daubois Jun 29, 2023 •

edited

Loading